linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Dmitry Monakhov <dmonakhov@openvz.org>
Cc: Christoph Hellwig <hch@infradead.org>,
	linux-fsdevel@vger.kernel.org, jack@suse.cz
Subject: Re: [PATCH 4/4] quota: add generic subtree quota support
Date: Tue, 16 Feb 2010 03:28:50 -0500	[thread overview]
Message-ID: <20100216082850.GA14821@infradead.org> (raw)
In-Reply-To: <87d405vb7r.fsf@openvz.org>

On Tue, Feb 16, 2010 at 11:25:28AM +0300, Dmitry Monakhov wrote:
> But this is not "project quota". Project quota is XFS feature.
> This patch aimed to give an opportunity to implement fs-specific
> quota_id mapping, and XFS is just an one of possible usecases.

What you desribe as subtree quota is exactly a slightly limited
implementation of project quotas.  And yes, fs-specific quota interfaces
are a horribly bad idea.  If you add features add them in generic code
and make them opt-in for a specific filesystem to support.

And yes, fs-specific quota interfaces are an utter nightmare, speaking
as the person fixing all this crap up right now.

---end quoted text---

  reply	other threads:[~2010-02-16  8:28 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-16  5:31 [PATCH 0/4] quota: RFC add extend quota type v2 Dmitry Monakhov
2010-02-16  5:31 ` [PATCH 1/4] quota: sb_quota state flags cleanup Dmitry Monakhov
2010-02-16  5:31   ` [PATCH 2/4] quota: generalize quota transfer interface Dmitry Monakhov
2010-02-16  5:31     ` [PATCH 3/4] introduce get_id callback Dmitry Monakhov
2010-02-16  5:31       ` [PATCH 4/4] quota: add generic subtree quota support Dmitry Monakhov
2010-02-16  8:14         ` Christoph Hellwig
2010-02-16  8:25           ` Dmitry Monakhov
2010-02-16  8:28             ` Christoph Hellwig [this message]
2010-02-16  8:56               ` Dmitry Monakhov
2010-02-16  9:03                 ` Christoph Hellwig
2010-02-16 21:13 ` [PATCH 0/4] quota: RFC add extend quota type v2 Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100216082850.GA14821@infradead.org \
    --to=hch@infradead.org \
    --cc=dmonakhov@openvz.org \
    --cc=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).