From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 4/4] quota: add generic subtree quota support Date: Tue, 16 Feb 2010 03:28:50 -0500 Message-ID: <20100216082850.GA14821@infradead.org> References: <1266298312-25885-1-git-send-email-dmonakhov@openvz.org> <1266298312-25885-2-git-send-email-dmonakhov@openvz.org> <1266298312-25885-3-git-send-email-dmonakhov@openvz.org> <1266298312-25885-4-git-send-email-dmonakhov@openvz.org> <1266298312-25885-5-git-send-email-dmonakhov@openvz.org> <20100216081426.GA2622@infradead.org> <87d405vb7r.fsf@openvz.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Christoph Hellwig , linux-fsdevel@vger.kernel.org, jack@suse.cz To: Dmitry Monakhov Return-path: Received: from bombadil.infradead.org ([18.85.46.34]:33434 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755355Ab0BPI2u (ORCPT ); Tue, 16 Feb 2010 03:28:50 -0500 Content-Disposition: inline In-Reply-To: <87d405vb7r.fsf@openvz.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Tue, Feb 16, 2010 at 11:25:28AM +0300, Dmitry Monakhov wrote: > But this is not "project quota". Project quota is XFS feature. > This patch aimed to give an opportunity to implement fs-specific > quota_id mapping, and XFS is just an one of possible usecases. What you desribe as subtree quota is exactly a slightly limited implementation of project quotas. And yes, fs-specific quota interfaces are a horribly bad idea. If you add features add them in generic code and make them opt-in for a specific filesystem to support. And yes, fs-specific quota interfaces are an utter nightmare, speaking as the person fixing all this crap up right now. ---end quoted text---