* [PATCH] VFS: clarify that nonseekable_open() will never fail
@ 2010-02-17 5:59 Dmitry Torokhov
0 siblings, 0 replies; only message in thread
From: Dmitry Torokhov @ 2010-02-17 5:59 UTC (permalink / raw)
To: Alexander Viro, Andrew Morton; +Cc: linux-fsdevel
Al, Andrew,
Could you please pick this one up (unless you disagree with it)?
Thanks!
--
Dmitry
VFS: clarify that nonseekable_open() will never fail
Acked-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: John Kacur <jkacur@redhat.com>
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
---
fs/open.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/fs/open.c b/fs/open.c
index 040cef7..02ceb73 100644
--- a/fs/open.c
+++ b/fs/open.c
@@ -1200,7 +1200,9 @@ EXPORT_SYMBOL(generic_file_open);
/*
* This is used by subsystems that don't want seekable
- * file descriptors
+ * file descriptors. The function is not supposed to ever fail, the only
+ * reason it returns an 'int' and not 'void' is so that it can be plugged
+ * directly into file_operations structure.
*/
int nonseekable_open(struct inode *inode, struct file *filp)
{
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2010-02-17 5:59 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-02-17 5:59 [PATCH] VFS: clarify that nonseekable_open() will never fail Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).