From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: [PATCH] VFS: clarify that nonseekable_open() will never fail Date: Tue, 16 Feb 2010 21:59:04 -0800 Message-ID: <20100217055903.GF7160@core.coreip.homeip.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org To: Alexander Viro , Andrew Morton Return-path: Received: from mail-yw0-f176.google.com ([209.85.211.176]:33834 "EHLO mail-yw0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751355Ab0BQF7K (ORCPT ); Wed, 17 Feb 2010 00:59:10 -0500 Received: by ywh6 with SMTP id 6so5295475ywh.4 for ; Tue, 16 Feb 2010 21:59:09 -0800 (PST) Content-Disposition: inline Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Al, Andrew, Could you please pick this one up (unless you disagree with it)? Thanks! -- Dmitry VFS: clarify that nonseekable_open() will never fail Acked-by: Arnd Bergmann Acked-by: John Kacur Signed-off-by: Dmitry Torokhov --- fs/open.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/fs/open.c b/fs/open.c index 040cef7..02ceb73 100644 --- a/fs/open.c +++ b/fs/open.c @@ -1200,7 +1200,9 @@ EXPORT_SYMBOL(generic_file_open); /* * This is used by subsystems that don't want seekable - * file descriptors + * file descriptors. The function is not supposed to ever fail, the only + * reason it returns an 'int' and not 'void' is so that it can be plugged + * directly into file_operations structure. */ int nonseekable_open(struct inode *inode, struct file *filp) {