From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ryusuke Konishi Subject: Re: [PATCH 11/19] nilfs2: replace inode uid,gid,mode initialization with helper function Date: Thu, 18 Feb 2010 10:28:13 +0900 (JST) Message-ID: <20100218.102813.19865144.ryusuke@osrg.net> References: <1266431353-8549-1-git-send-email-dmonakhov@openvz.org> <1266432168-9457-1-git-send-email-dmonakhov@openvz.org> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: linux-fsdevel@vger.kernel.org, konishi.ryusuke@lab.ntt.co.jp To: dmonakhov@openvz.org Return-path: Received: from sh.osrg.net ([192.16.179.4]:51423 "EHLO sh.osrg.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751657Ab0BRB3M (ORCPT ); Wed, 17 Feb 2010 20:29:12 -0500 In-Reply-To: <1266432168-9457-1-git-send-email-dmonakhov@openvz.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed, 17 Feb 2010 21:42:48 +0300, Dmitry Monakhov wrote: > > Signed-off-by: Dmitry Monakhov > --- > fs/nilfs2/inode.c | 11 +---------- > 1 files changed, 1 insertions(+), 10 deletions(-) > > diff --git a/fs/nilfs2/inode.c b/fs/nilfs2/inode.c > index 7868cc1..5d8e866 100644 > --- a/fs/nilfs2/inode.c > +++ b/fs/nilfs2/inode.c > @@ -279,16 +279,7 @@ struct inode *nilfs_new_inode(struct inode *dir, int mode) > /* reference count of i_bh inherits from nilfs_mdt_read_block() */ > > atomic_inc(&sbi->s_inodes_count); > - > - inode->i_uid = current_fsuid(); > - if (dir->i_mode & S_ISGID) { > - inode->i_gid = dir->i_gid; > - if (S_ISDIR(mode)) > - mode |= S_ISGID; > - } else > - inode->i_gid = current_fsgid(); > - > - inode->i_mode = mode; > + inode_init_owner(inode, dir, mode); > inode->i_ino = ino; > inode->i_mtime = inode->i_atime = inode->i_ctime = CURRENT_TIME; > > -- > 1.6.6 Looks fine to me. Acked-by: Ryusuke Konishi