Re: [PATCH 18/19] udf: replace inode uid,gid,mode init with helper v2

[Jan Kara <jack@suse.cz>]

On Thu 18-02-10 10:18:32, Dmitry Monakhov wrote:
> Jan Kara <jack@suse.cz> writes:
> 
> > On Wed 17-02-10 21:47:06, Dmitry Monakhov wrote:
> >> 
> >> Signed-off-by: Dmitry Monakhov <dmonakhov@openvz.org>
> >> ---
> >>  fs/udf/ialloc.c |   11 ++---------
> >>  fs/udf/namei.c  |    3 ---
> >>  2 files changed, 2 insertions(+), 12 deletions(-)
> >   Hmm, this patch looks kind of half baked. There are several calls to
> > udf_new_inode() in udf/namei.c. From your patch I'd expect they all should
> > pass correct final mode to udf_new_inode which they currently don't to (the
> > case of udf_mkdir and udf_symlink). Otherwise I'm fine with this change.
> Yeah, you right. I was to lazy to check all callers :(.
> Correct version are follows:

> From 612e46abea261e9fdaea5f3285c5deee4f86f162 Mon Sep 17 00:00:00 2001
> From: Dmitry Monakhov <dmonakhov@openvz.org>
> Date: Thu, 18 Feb 2010 09:42:52 +0300
> Subject: [PATCH 18/19] udf: replace inode uid,gid,mode init with helper v2
> 
> 
> Signed-off-by: Dmitry Monakhov <dmonakhov@openvz.org>
> ---
>  fs/udf/ialloc.c |   11 ++---------
>  fs/udf/namei.c  |    8 +-------
>  2 files changed, 3 insertions(+), 16 deletions(-)
> 
> diff --git a/fs/udf/ialloc.c b/fs/udf/ialloc.c
> index c10fa39..52d6e4d 100644
> --- a/fs/udf/ialloc.c
> +++ b/fs/udf/ialloc.c
> @@ -691,9 +689,6 @@ static int udf_mkdir(struct inode *dir, struct dentry *dentry, int mode)
>  			FID_FILE_CHAR_DIRECTORY | FID_FILE_CHAR_PARENT;
>  	udf_write_fi(inode, &cfi, fi, &fibh, NULL, NULL);
>  	brelse(fibh.sbh);
> -	inode->i_mode = S_IFDIR | mode;
> -	if (dir->i_mode & S_ISGID)
> -		inode->i_mode |= S_ISGID;
>  	mark_inode_dirty(inode);
>  
>  	fi = udf_add_entry(dir, dentry, &fibh, &cfi, &err);
  I think you're still missing to call udf_new_inode with S_IFDIR | mode in
this function.

										Honza
-- 
Jan Kara <jack@suse.cz>
SUSE Labs, CR