From: Al Viro <viro@ZenIV.linux.org.uk>
To: Valerie Aurora <vaurora@redhat.com>
Cc: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [RFC PATCH] VFS: Simplify truncate logic in do_filp_open()
Date: Mon, 22 Feb 2010 21:08:27 +0000 [thread overview]
Message-ID: <20100222210827.GF30031@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20100222203551.GE972@shell>
On Mon, Feb 22, 2010 at 03:35:51PM -0500, Valerie Aurora wrote:
> The fact that may_open() could truncate a file gave me a lot of
> heartburn when working on union mounts, so I was thrilled to see that
> truncate handling has been moved out of may_open() in Al's for-next
> tree. However, it seems to me that the surrounding elaborate
> mnt_want_write() dance is no longer needed? If so, this also
> simplifies Ogawa Hirofumi "Fix use-after-free of vfsmount by
> mnt_drop_write()" patch.
>
> Against Al's for-next branch. Lightly tested, please review.
Val, anything around do_filp_open() should be on top of #untested. The
whole area gets rewritten there.
next prev parent reply other threads:[~2010-02-22 21:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-22 20:35 [RFC PATCH] VFS: Simplify truncate logic in do_filp_open() Valerie Aurora
2010-02-22 21:08 ` Al Viro [this message]
2010-02-23 19:05 ` Valerie Aurora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100222210827.GF30031@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=hirofumi@mail.parknet.co.jp \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vaurora@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).