From mboxrd@z Thu Jan 1 00:00:00 1970 From: Valerie Aurora Subject: Re: [RFC PATCH] VFS: Simplify truncate logic in do_filp_open() Date: Tue, 23 Feb 2010 14:05:52 -0500 Message-ID: <20100223190551.GA6377@shell> References: <20100222203551.GE972@shell> <20100222210827.GF30031@ZenIV.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: OGAWA Hirofumi , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org To: Al Viro Return-path: Content-Disposition: inline In-Reply-To: <20100222210827.GF30031@ZenIV.linux.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Mon, Feb 22, 2010 at 09:08:27PM +0000, Al Viro wrote: > On Mon, Feb 22, 2010 at 03:35:51PM -0500, Valerie Aurora wrote: > > The fact that may_open() could truncate a file gave me a lot of > > heartburn when working on union mounts, so I was thrilled to see that > > truncate handling has been moved out of may_open() in Al's for-next > > tree. However, it seems to me that the surrounding elaborate > > mnt_want_write() dance is no longer needed? If so, this also > > simplifies Ogawa Hirofumi "Fix use-after-free of vfsmount by > > mnt_drop_write()" patch. > > > > Against Al's for-next branch. Lightly tested, please review. > > Val, anything around do_filp_open() should be on top of #untested. The > whole area gets rewritten there. Nice! That's a huge improvement. I will happily rebase. Thanks, -VAL