From: Jan Kara <jack@suse.cz>
To: Camille Moncelier <pix@devlife.org>
Cc: "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
ext4 development <linux-ext4@vger.kernel.org>,
Jan Kara <jack@suse.cz>
Subject: Re: [ext3] Changes to block device after an ext3 mount point has been remounted readonly
Date: Wed, 24 Feb 2010 17:59:41 +0100 [thread overview]
Message-ID: <20100224165940.GM3687@quack.suse.cz> (raw)
In-Reply-To: <baaef4711002240826t1b447662yf66c980dea1d9d00@mail.gmail.com>
On Wed 24-02-10 17:26:37, Camille Moncelier wrote:
> > Theoretically some pages may exist after rw=>ro remount
> > because of generic race between write/sync, And they will be written
> > in by writepage if page already has buffers. This not happen in ext4
> > because. Each time it try to perform writepages it try to start_journal
> > and this result in EROFS.
> > The race bug will be closed some day but new one may appear again.
> >
> > Let's be honest and change ext3 writepage like follows:
> > - check ROFS flag inside write page
> > - dump writepage's errors.
> >
> >
> I think I don't understand correctly your patch. For me it seems that
> when an ext3 filesystem is remounted ro, some data may not have been
> written to disk right ?
I think that Dmitry was concerned about the fact that a process could
open a file and write to it after we synced the filesystem in
do_remount_sb().
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
next prev parent reply other threads:[~2010-02-24 16:59 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-18 16:45 [ext3] Changes to block device after an ext3 mount point has been remounted readonly PiX
2010-02-18 16:50 ` Camille Moncelier
2010-02-18 21:41 ` Andreas Dilger
2010-02-19 7:38 ` Camille Moncelier
2010-02-22 22:32 ` Jan Kara
2010-02-22 23:05 ` Jan Kara
2010-02-22 23:09 ` Andreas Dilger
2010-02-23 8:42 ` Camille Moncelier
2010-02-23 13:55 ` Jan Kara
2010-02-24 16:01 ` Dmitry Monakhov
2010-02-24 16:26 ` Camille Moncelier
2010-02-24 16:59 ` Jan Kara [this message]
2010-02-24 16:56 ` Jan Kara
2010-03-02 9:34 ` Christoph Hellwig
2010-03-02 10:01 ` Dmitry Monakhov
2010-03-02 13:26 ` Jan Kara
2010-03-02 23:10 ` Joel Becker
2010-02-24 16:57 ` Eric Sandeen
2010-02-24 17:05 ` Jan Kara
2010-02-24 17:26 ` Dmitry Monakhov
2010-02-24 21:36 ` Jan Kara
2010-03-02 10:29 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100224165940.GM3687@quack.suse.cz \
--to=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=pix@devlife.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).