From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 4/8] dquot: cleanup dquot transfer routine Date: Mon, 1 Mar 2010 04:50:52 -0500 Message-ID: <20100301095052.GA2869@infradead.org> References: <20100220115101.469826792@bombadil.infradead.org> <20100220115213.269522934@bombadil.infradead.org> <20100224231413.GE3097@quack.suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Christoph Hellwig , linux-fsdevel@vger.kernel.org To: Jan Kara Return-path: Received: from bombadil.infradead.org ([18.85.46.34]:42651 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751010Ab0CAJux (ORCPT ); Mon, 1 Mar 2010 04:50:53 -0500 Content-Disposition: inline In-Reply-To: <20100224231413.GE3097@quack.suse.cz> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Thu, Feb 25, 2010 at 12:14:14AM +0100, Jan Kara wrote: > On Sat 20-02-10 06:51:05, Christoph Hellwig wrote: > > Get rid of the transfer dquot operation - it is now always called from > > the filesystem and if a filesystem really needs it's own (which none > > currently does) it can just call into it's own routine directly. > > > > Rename the now static low-level dquot_transfer helper to __dquot_transfer > > and vfs_dq_transfer to dquot_transfer to have a consistent namespace, > > and make the new dquot_transfer return a normal negative errno value > > which all callers expect. > Looks good. I just wonder - if you made dquot_transfer() return error > code, shouldn't also dquot_alloc_inode, dquot_alloc_space and similar > return error code instead of 1? It would seem more consistent. Probably - I can do that in another pass if you haven't done it yet.