From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kara Subject: Re: [PATCH 4/8] dquot: cleanup dquot transfer routine Date: Mon, 1 Mar 2010 11:40:53 +0100 Message-ID: <20100301104052.GA3271@quack.suse.cz> References: <20100220115101.469826792@bombadil.infradead.org> <20100220115213.269522934@bombadil.infradead.org> <20100224231413.GE3097@quack.suse.cz> <20100301095052.GA2869@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jan Kara , linux-fsdevel@vger.kernel.org To: Christoph Hellwig Return-path: Received: from cantor.suse.de ([195.135.220.2]:51472 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750966Ab0CAKkm (ORCPT ); Mon, 1 Mar 2010 05:40:42 -0500 Content-Disposition: inline In-Reply-To: <20100301095052.GA2869@infradead.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon 01-03-10 04:50:52, Christoph Hellwig wrote: > On Thu, Feb 25, 2010 at 12:14:14AM +0100, Jan Kara wrote: > > On Sat 20-02-10 06:51:05, Christoph Hellwig wrote: > > > Get rid of the transfer dquot operation - it is now always called from > > > the filesystem and if a filesystem really needs it's own (which none > > > currently does) it can just call into it's own routine directly. > > > > > > Rename the now static low-level dquot_transfer helper to __dquot_transfer > > > and vfs_dq_transfer to dquot_transfer to have a consistent namespace, > > > and make the new dquot_transfer return a normal negative errno value > > > which all callers expect. > > Looks good. I just wonder - if you made dquot_transfer() return error > > code, shouldn't also dquot_alloc_inode, dquot_alloc_space and similar > > return error code instead of 1? It would seem more consistent. > > Probably - I can do that in another pass if you haven't done it yet. I've already done it. See commits 3a3d2903d3e9aaba9ca154606cf2f2613839b079 and bff3333e868578990f6fe794a7cba0c74bd433ac in my linux-fs-2.6 tree. Honza -- Jan Kara SUSE Labs, CR