From: Christoph Hellwig <hch@lst.de>
To: hirofumi@mail.parknet.co.jp, chris.mason@oracle.com
Cc: linux-fsdevel@vger.kernel.org
Subject: vfat vs msdos and -o flush
Date: Mon, 1 Mar 2010 18:08:27 +0100 [thread overview]
Message-ID: <20100301170827.GA5142@lst.de> (raw)
Commit ae78bf9c4f5fde3c67e2829505f195d7347ce3e4 added a -o flush
option to the fat driver back in 2006, which causes asynchronous
writeout after I/O operations ASAP. This already is quite hacky
and not something I like very much, but even worse the option
is accepted when using the more common vfat filesysten type, but
only actually implemented for the less common legacy msdos
filesystem type.
This tells us two lessons:
- the -o flush option probably never got a whole lot of exposure
and users didn't notice it doesn't work. We might as well just
remove it again
- having the highlevel inode operations duplicated between msdos
and vfat is probably a bad idea, and we should only branch out
for the very low-level directory entry manipulations.
next reply other threads:[~2010-03-01 17:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-01 17:08 Christoph Hellwig [this message]
2010-03-03 13:36 ` vfat vs msdos and -o flush OGAWA Hirofumi
2010-03-07 11:00 ` OGAWA Hirofumi
2010-03-07 13:06 ` Christoph Hellwig
2010-03-07 14:15 ` OGAWA Hirofumi
2010-03-09 12:57 ` Christoph Hellwig
2010-03-09 13:42 ` Chris Mason
2010-03-10 19:19 ` Jeff Mahoney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100301170827.GA5142@lst.de \
--to=hch@lst.de \
--cc=chris.mason@oracle.com \
--cc=hirofumi@mail.parknet.co.jp \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).