From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: vfat vs msdos and -o flush Date: Mon, 1 Mar 2010 18:08:27 +0100 Message-ID: <20100301170827.GA5142@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org To: hirofumi@mail.parknet.co.jp, chris.mason@oracle.com Return-path: Received: from verein.lst.de ([213.95.11.210]:46427 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750844Ab0CARIn (ORCPT ); Mon, 1 Mar 2010 12:08:43 -0500 Content-Disposition: inline Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Commit ae78bf9c4f5fde3c67e2829505f195d7347ce3e4 added a -o flush option to the fat driver back in 2006, which causes asynchronous writeout after I/O operations ASAP. This already is quite hacky and not something I like very much, but even worse the option is accepted when using the more common vfat filesysten type, but only actually implemented for the less common legacy msdos filesystem type. This tells us two lessons: - the -o flush option probably never got a whole lot of exposure and users didn't notice it doesn't work. We might as well just remove it again - having the highlevel inode operations duplicated between msdos and vfat is probably a bad idea, and we should only branch out for the very low-level directory entry manipulations.