From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kara Subject: Re: commiting unreviewed patches, was Re: [PATCH 4/8] dquot: cleanup dquot transfer routine Date: Tue, 2 Mar 2010 18:43:09 +0100 Message-ID: <20100302174309.GF3829@quack.suse.cz> References: <20100220115101.469826792@bombadil.infradead.org> <20100220115213.269522934@bombadil.infradead.org> <20100224231413.GE3097@quack.suse.cz> <20100301095052.GA2869@infradead.org> <20100301104052.GA3271@quack.suse.cz> <87d3zo8f0s.fsf@openvz.org> <20100301134544.GH3271@quack.suse.cz> <20100301141826.GA2584@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jan Kara , Dmitry Monakhov , linux-fsdevel@vger.kernel.org To: Christoph Hellwig Return-path: Received: from cantor2.suse.de ([195.135.220.15]:46001 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753238Ab0CBRm7 (ORCPT ); Tue, 2 Mar 2010 12:42:59 -0500 Content-Disposition: inline In-Reply-To: <20100301141826.GA2584@infradead.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon 01-03-10 09:18:26, Christoph Hellwig wrote: > > Hmm, probably I was too tired on Wednesday and didn't push after > > committing changes. Sorry for that. Now they are pushed. The web interface > > should mirror them soon... > > Btw, I'd appreciate it if you would not commit unreviewed patches to > your trees. E.g. commit 58b308dcac935d803618f9b06909d4355dfdf5b6 > introduces a fishy and unessecary call to fsync_bdev which could > just be a sync_filesystem which even requires a workaround in commit > 9007983e9bf994200194727bcb87d45bb924b4a8. Fair enough. I've created new branch for_testing in my tree where I'll put patches like this which haven't been sent for review yet. Regarding this particular change, I've changed fsync_bdev to sync_filesystem, removed 9007983e9bf994200194727bcb87d45bb924b4a8, and sent the patch for review... Honza -- Jan Kara SUSE Labs, CR