From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH] quota: Properly invalidate caches even for filesystems with blocksize < pagesize Date: Tue, 2 Mar 2010 12:56:17 -0500 Message-ID: <20100302175617.GA24237@infradead.org> References: <1267551647-12438-1-git-send-email-jack@suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org, hch@infradead.org, dmonakhov@openvz.org To: Jan Kara Return-path: Received: from bombadil.infradead.org ([18.85.46.34]:50265 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751546Ab0CBR4S (ORCPT ); Tue, 2 Mar 2010 12:56:18 -0500 Content-Disposition: inline In-Reply-To: <1267551647-12438-1-git-send-email-jack@suse.cz> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Tue, Mar 02, 2010 at 06:40:47PM +0100, Jan Kara wrote: > Sometimes invalidate_bdev() can fail to invalidate a part of block > device cache because of dirty data. If the filesystem has blocksize > smaller than page size, this can happen even for pages containing > quota files and thus kernel would operate on stale data. Fix the > issue by syncing the filesystem before invalidating the cache. Looks good to me, Reviewed-by: Christoph Hellwig