From: Christoph Hellwig <hch@infradead.org>
To: Jan Kara <jack@suse.cz>
Cc: Christoph Hellwig <hch@infradead.org>, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 7/8] dquot: move dquot initialization responsibiliy into the filesystem
Date: Tue, 2 Mar 2010 14:50:40 -0500 [thread overview]
Message-ID: <20100302195040.GA754@infradead.org> (raw)
In-Reply-To: <20100302184437.GG3829@quack.suse.cz>
On Tue, Mar 02, 2010 at 07:44:38PM +0100, Jan Kara wrote:
> I've looked at the patch. I have several comments:
> It seems that conversion of UDF is completely missing from the patch.
Indeed. UDF also got left out at least from the dquot transfer patch
which should have added one to it. Do you want me to respin those
patches to include udf?
> Also it seems that UFS is missing conversion of ufs_setattr to call
> vfs_dq_init when ATTR_SIZE is set.
Indeed. I'm pretty sure I did these, but can't find them in my patch
anymore. Probably got lost to some quilt interaction.
> Finally, ocfs2 is missing conversion
> of ocfs2_open so that it calls vfs_dq_init.
ocfs2 calls vfs_dq_init manually.
> > +++ linux-2.6/fs/ocfs2/file.c 2010-02-20 12:00:45.648255722 +0100
> > @@ -976,6 +979,9 @@ int ocfs2_setattr(struct dentry *dentry,
> > if (status)
> > return status;
> >
> > + if (attr->ia_valid & ATTR_SIZE)
> > + vfs_dq_init(inode);
> > +
> > size_change = S_ISREG(inode->i_mode) && attr->ia_valid & ATTR_SIZE;
> > if (size_change) {
> > status = ocfs2_rw_lock(inode, 1);
> We can merge the above two conditions...
Ok.
next prev parent reply other threads:[~2010-03-02 19:50 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-20 11:51 [PATCH 0/8] dquot interface cleanups Christoph Hellwig
2010-02-20 11:51 ` [PATCH 1/8] dquot: cleanup space allocation / freeing routines Christoph Hellwig
2010-02-24 22:09 ` Jan Kara
2010-02-20 11:51 ` [PATCH 2/8] dquot: cleanup inode " Christoph Hellwig
2010-02-24 22:39 ` Jan Kara
2010-02-20 11:51 ` [PATCH 3/8] dquot: move dquot transfer responsibiliy into the filesystem Christoph Hellwig
2010-02-24 23:06 ` Jan Kara
2010-02-20 11:51 ` [PATCH 4/8] dquot: cleanup dquot transfer routine Christoph Hellwig
2010-02-24 23:14 ` Jan Kara
2010-03-01 9:50 ` Christoph Hellwig
2010-03-01 10:40 ` Jan Kara
2010-03-01 11:20 ` Dmitry Monakhov
2010-03-01 13:45 ` Jan Kara
2010-03-01 14:18 ` commiting unreviewed patches, was " Christoph Hellwig
2010-03-02 17:43 ` Jan Kara
2010-02-20 11:51 ` [PATCH 5/8] dquot: move dquot drop responsibiliy into the filesystem Christoph Hellwig
2010-02-25 0:00 ` Jan Kara
2010-02-20 11:51 ` [PATCH 6/8] dquot: cleanup dquot drop routine Christoph Hellwig
2010-02-25 0:08 ` Jan Kara
2010-02-20 11:51 ` [PATCH 7/8] dquot: move dquot initialization responsibiliy into the filesystem Christoph Hellwig
2010-02-25 0:29 ` Jan Kara
2010-03-02 18:44 ` Jan Kara
2010-03-02 19:50 ` Christoph Hellwig [this message]
2010-03-03 8:16 ` Jan Kara
2010-03-03 13:02 ` Christoph Hellwig
2010-02-20 11:51 ` [PATCH 8/8] dquot: cleanup dquot initialize routine Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100302195040.GA754@infradead.org \
--to=hch@infradead.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).