From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 7/8] dquot: move dquot initialization responsibiliy into the filesystem Date: Tue, 2 Mar 2010 14:50:40 -0500 Message-ID: <20100302195040.GA754@infradead.org> References: <20100220115101.469826792@bombadil.infradead.org> <20100220115213.803253745@bombadil.infradead.org> <20100302184437.GG3829@quack.suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Christoph Hellwig , linux-fsdevel@vger.kernel.org To: Jan Kara Return-path: Received: from bombadil.infradead.org ([18.85.46.34]:34574 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752524Ab0CBTul (ORCPT ); Tue, 2 Mar 2010 14:50:41 -0500 Content-Disposition: inline In-Reply-To: <20100302184437.GG3829@quack.suse.cz> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Tue, Mar 02, 2010 at 07:44:38PM +0100, Jan Kara wrote: > I've looked at the patch. I have several comments: > It seems that conversion of UDF is completely missing from the patch. Indeed. UDF also got left out at least from the dquot transfer patch which should have added one to it. Do you want me to respin those patches to include udf? > Also it seems that UFS is missing conversion of ufs_setattr to call > vfs_dq_init when ATTR_SIZE is set. Indeed. I'm pretty sure I did these, but can't find them in my patch anymore. Probably got lost to some quilt interaction. > Finally, ocfs2 is missing conversion > of ocfs2_open so that it calls vfs_dq_init. ocfs2 calls vfs_dq_init manually. > > +++ linux-2.6/fs/ocfs2/file.c 2010-02-20 12:00:45.648255722 +0100 > > @@ -976,6 +979,9 @@ int ocfs2_setattr(struct dentry *dentry, > > if (status) > > return status; > > > > + if (attr->ia_valid & ATTR_SIZE) > > + vfs_dq_init(inode); > > + > > size_change = S_ISREG(inode->i_mode) && attr->ia_valid & ATTR_SIZE; > > if (size_change) { > > status = ocfs2_rw_lock(inode, 1); > We can merge the above two conditions... Ok.