From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kara Subject: Re: [PATCH 7/8] dquot: move dquot initialization responsibiliy into the filesystem Date: Wed, 3 Mar 2010 09:16:03 +0100 Message-ID: <20100303081602.GC6290@quack.suse.cz> References: <20100220115101.469826792@bombadil.infradead.org> <20100220115213.803253745@bombadil.infradead.org> <20100302184437.GG3829@quack.suse.cz> <20100302195040.GA754@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jan Kara , linux-fsdevel@vger.kernel.org To: Christoph Hellwig Return-path: Received: from cantor2.suse.de ([195.135.220.15]:41913 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753928Ab0CCIPx (ORCPT ); Wed, 3 Mar 2010 03:15:53 -0500 Content-Disposition: inline In-Reply-To: <20100302195040.GA754@infradead.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Tue 02-03-10 14:50:40, Christoph Hellwig wrote: > On Tue, Mar 02, 2010 at 07:44:38PM +0100, Jan Kara wrote: > > I've looked at the patch. I have several comments: > > It seems that conversion of UDF is completely missing from the patch. > > Indeed. UDF also got left out at least from the dquot transfer patch > which should have added one to it. Do you want me to respin those > patches to include udf? Yes, please respin dquot_transfer patches and dquot_drop seems to also have the problem so those ones as well. > > Also it seems that UFS is missing conversion of ufs_setattr to call > > vfs_dq_init when ATTR_SIZE is set. > > Indeed. I'm pretty sure I did these, but can't find them in my patch > anymore. Probably got lost to some quilt interaction. > > > Finally, ocfs2 is missing conversion > > of ocfs2_open so that it calls vfs_dq_init. > > ocfs2 calls vfs_dq_init manually. Ah, my fault, now I see it in the patch. Honza -- Jan Kara SUSE Labs, CR