From: Randy Dunlap <randy.dunlap@oracle.com>
To: Josef Bacik <josef@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cleanup __generic_block_fiemap and fix a few minor issues
Date: Thu, 4 Mar 2010 09:23:20 -0800 [thread overview]
Message-ID: <20100304092320.12b09851.randy.dunlap@oracle.com> (raw)
In-Reply-To: <20100304171253.GB5722@localhost.localdomain>
On Thu, 4 Mar 2010 12:12:54 -0500 Josef Bacik wrote:
> diff --git a/fs/ioctl.c b/fs/ioctl.c
> index 6c75110..f330fec 100644
> --- a/fs/ioctl.c
> +++ b/fs/ioctl.c
> @@ -228,14 +228,23 @@ static int ioctl_fiemap(struct file *filp, unsigned long arg)
>
>
> /**
> * __generic_block_fiemap - FIEMAP for block based inodes (no locking)
> - * @inode - the inode to map
> - * @arg - the pointer to userspace where we copy everything to
> - * @get_block - the fs's get_block function
> + * @inode: the inode to map
> + * @fieinfo: the fiemap info struct that will be passed back to userspace
> + * @start: where to start mapping in the inode
> + * @len: how much space to map
> + * @get_block: the fs's get_block function
> *
> * This does FIEMAP for block based inodes. Basically it will just loop
> * through get_block until we hit the number of extents we want to map, or we
That's good. Thank you.
---
~Randy
next prev parent reply other threads:[~2010-03-04 17:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-03 16:37 [PATCH] cleanup __generic_block_fiemap and fix a few minor issues Josef Bacik
2010-03-04 16:03 ` Linus Torvalds
2010-03-04 16:20 ` Josef Bacik
2010-03-04 16:50 ` Randy Dunlap
2010-03-04 17:12 ` Josef Bacik
2010-03-04 17:23 ` Randy Dunlap [this message]
2010-03-29 18:05 ` Josef Bacik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100304092320.12b09851.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=josef@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).