From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kara Subject: Re: [PATCH 1/2] quota: merge __dquot_transfer into dquot_transfer Date: Mon, 8 Mar 2010 19:04:33 +0100 Message-ID: <20100308180433.GH5644@quack.suse.cz> References: <20100306131753.GA28278@infradead.org> <20100308171133.GF5644@quack.suse.cz> <20100308171308.GA28427@infradead.org> <20100308173928.GG5644@quack.suse.cz> <20100308174207.GA17103@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jan Kara , linux-fsdevel@vger.kernel.org, dmonakhov@openvz.org To: Christoph Hellwig Return-path: Received: from cantor2.suse.de ([195.135.220.15]:43721 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754590Ab0CHSEX (ORCPT ); Mon, 8 Mar 2010 13:04:23 -0500 Content-Disposition: inline In-Reply-To: <20100308174207.GA17103@infradead.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon 08-03-10 12:42:07, Christoph Hellwig wrote: > On Mon, Mar 08, 2010 at 06:39:28PM +0100, Jan Kara wrote: > > > Dmitri will have to add code to grab the project ID somewhere. His > > > patch made that easier when the two functions were split over an > > > indirect call boundary, but now that this is gone it's not needed > > > anymore. One line still needs to be added, and that's in the ne > > > dquot_transfer. > > Hmm, but dquot_transfer gets new uid/gid from struct iattr. So either > > we have to extend struct iattr to accompany also project_id changes (fine > > with me) or we have to keep interface similar to __dquot_transfer. Do > > you have any preference? > > If we promote the project ID to a first level VFS object like the > last series does we should also add it to struct iattr. Anyway, I need OK, that would make sence. > to look through the project ID patches in more detail, I'm not quite > happy yet with what I saw from quickly skipping over them. I'll try to > get back to it tomorrow. OK, I'll wait for a few days to see what you and Dmitry to agree on before merging the patch. We are not in any hurry now... Honza -- Jan Kara SUSE Labs, CR