linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: tytso@mit.edu
To: Evgeniy Ivanov <lolkaantimat@gmail.com>
Cc: linux-fsdevel@vger.kernel.org
Subject: Re: few ext2/ext3 questions (i_blocks usage and updating superblock in r-only)
Date: Tue, 9 Mar 2010 11:46:35 -0500	[thread overview]
Message-ID: <20100309164635.GF13487@thunk.org> (raw)
In-Reply-To: <e1e08eb01003090727p15eb7046nbce991899b0abc30@mail.gmail.com>

On Tue, Mar 09, 2010 at 06:27:27PM +0300, Evgeniy Ivanov wrote:
> Hello,
> 
> What is correct way to treat i_blocks? i_blocks is a block counter,
> but its values differ from real number of used blocks (e.g. 1 block is
> used and written to i_block, but i_blocks is set to 8 and if I set
> i_blocks to 1 e2fsck always wants to set it to 8). As I understand
> preallocation shouldn't affect i_blocks and there are no unix holes.

This is a question which is better asked on
linux-ext4@vger.kernel.org, since it's an ext4 specific question.

i_blocks was historically marked in units of 512 byte sectors because
st_blocks as returned by stat(2) is in units of 512 byte sectors, and
so it was easier to pass i_blocks straight on through to st_blocks.

In ext4, if the HUGE_FL flag set in the inode's i_flags, and
EXT4_FEATURE_RO_COMPAT_HUGE_FILE feature flag is set, then i_blocks is
stored in units of the file system block size, and it's up to ext4's
stat method to convert that to the units expected by st_blocks.

> Nothing on fs should be updated, when it's mounted in r-only (I mean
> mount time, mount point attributes of superblock), right?

Correct.

> Btw, when I don't have problems with i_blocks, e2fsck's exit status is
> 1 (my ext2 implementation is guilty), but it doesn't say what was
> wrong even with "-v". How can I get more verbose results?

The exit status of 1 means that something was changed by fsck.  See
the man page for fsck or e2fsck, in the "EXIT CODES" section.  There
were a few cases where e2fsck didn't explain what it was that it fixed
up or updated, but I thought all of that has been fixed.  What version
of e2fsck are you using, and can you easily replicate this?  If so,
I'd like to see a file system image.

					- Ted

      reply	other threads:[~2010-03-09 16:46 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <e1e08eb01003090721q306a7bday7b47bca9bae691e@mail.gmail.com>
2010-03-09 15:27 ` few ext2/ext3 questions (i_blocks usage and updating superblock in r-only) Evgeniy Ivanov
2010-03-09 16:46   ` tytso [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100309164635.GF13487@thunk.org \
    --to=tytso@mit.edu \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=lolkaantimat@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).