From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wu Fengguang Subject: [PATCH] vfs: O_* bit numbers uniqueness check fix Date: Fri, 12 Mar 2010 21:41:16 +0800 Message-ID: <20100312134116.GA6502@localhost> References: <201003112211.o2BMBLfm013822@imap1.linux-foundation.org> <1268349064.3768.3.camel@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "akpm@linux-foundation.org" , "viro@zeniv.linux.org.uk" , "linux-fsdevel@vger.kernel.org" , "davem@davemloft.net" , "hch@infradead.org" , "jamie@shareable.org" , "rdreier@cisco.com" , "schwab@linux-m68k.org" , "sfr@canb.auug.org.au" To: Eric Paris Return-path: Received: from mga11.intel.com ([192.55.52.93]:23273 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751182Ab0CLOfT (ORCPT ); Fri, 12 Mar 2010 09:35:19 -0500 Content-Disposition: inline In-Reply-To: <1268349064.3768.3.camel@localhost> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Follow the comment by Eric: Until the FMODE_ and O_ bits do not overload I think we need to check FMODE_EXEC and FMODE_NONOTIFY (if you have that one) inside fcntl_init() as well. I guess I'll send a patch to someone ?Al? to add FMODE_EXEC to the list.... CC: Eric Paris Signed-off-by: Wu Fengguang --- fs/fcntl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- linux-mm.orig/fs/fcntl.c 2010-03-12 21:27:12.000000000 +0800 +++ linux-mm/fs/fcntl.c 2010-03-12 21:38:51.000000000 +0800 @@ -748,7 +748,8 @@ static int __init fcntl_init(void) O_TRUNC | O_APPEND | O_NONBLOCK | __O_SYNC | O_DSYNC | FASYNC | O_DIRECT | O_LARGEFILE | O_DIRECTORY | - O_NOFOLLOW | O_NOATIME | O_CLOEXEC + O_NOFOLLOW | O_NOATIME | O_CLOEXEC | + FMODE_EXEC )); fasync_cache = kmem_cache_create("fasync_cache",