From mboxrd@z Thu Jan 1 00:00:00 1970 From: Valerie Aurora Subject: Re: [rfc][patch] fs: mntput might sleep Date: Wed, 17 Mar 2010 21:12:22 -0400 Message-ID: <20100318011222.GB24348@shell> References: <20100317132820.GH2869@laptop> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org, Al Viro To: Nick Piggin Return-path: Received: from mx1.redhat.com ([209.132.183.28]:39545 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752064Ab0CRBM0 (ORCPT ); Wed, 17 Mar 2010 21:12:26 -0400 Content-Disposition: inline In-Reply-To: <20100317132820.GH2869@laptop> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Thu, Mar 18, 2010 at 12:28:20AM +1100, Nick Piggin wrote: > I missed this once or twice, so can we put might_sleep check into > mntput? Or does anyone call it from atomic context to drop a known > not-last reference? (if so then maybe the caller could be rewritten). > -- > Index: linux-2.6/include/linux/mount.h > =================================================================== > --- linux-2.6.orig/include/linux/mount.h > +++ linux-2.6/include/linux/mount.h > @@ -113,6 +113,8 @@ extern int __mnt_is_readonly(struct vfsm > static inline void mntput(struct vfsmount *mnt) > { > if (mnt) { > + might_sleep(); > + > mnt->mnt_expiry_mark = 0; > mntput_no_expire(mnt); > } None of my union mount tests trigger it, fine by me. :) -VAL