From: Nick Piggin <npiggin@suse.de>
To: Steve French <smfrench@gmail.com>
Cc: linux-fsdevel@vger.kernel.org, linux-cifs-client@lists.samba.org,
Steve French <sfrench@samba.org>
Subject: Re: [patch] cifs: use add_to_page_cache_lru
Date: Fri, 19 Mar 2010 12:13:10 +1100 [thread overview]
Message-ID: <20100319011310.GG25636@laptop> (raw)
In-Reply-To: <524f69651003181143i67d2fbbdw148619b6065bca88@mail.gmail.com>
On Thu, Mar 18, 2010 at 01:43:17PM -0500, Steve French wrote:
> Seems reasonable to me (also Shaggy acked this). Any idea how likely
> it would affect performance (and would thus need to run through some
> simple iozone and cthon (timing mode) or similar perf testing)
It should positively affect LRU ordering, and CPU efficiency, but both
such a tiny amount it should be in the noise. It wouldn't affect IO
patterns (except as a side effect of slightly different pagecache
reclaim, but again in the noise).
I wouldn't worry about benchmarking it.
next prev parent reply other threads:[~2010-03-19 1:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-17 6:23 [patch] cifs: use add_to_page_cache_lru Nick Piggin
2010-03-18 18:43 ` Steve French
2010-03-19 1:13 ` Nick Piggin [this message]
2010-04-21 3:31 ` Steve French
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100319011310.GG25636@laptop \
--to=npiggin@suse.de \
--cc=linux-cifs-client@lists.samba.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=sfrench@samba.org \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).