From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Serge E. Hallyn" Subject: Re: [C/R v20][PATCH 38/96] c/r: dump open file descriptors Date: Sun, 21 Mar 2010 21:55:03 -0500 Message-ID: <20100322025503.GA13280@hallyn.com> References: <1268960401-16680-1-git-send-email-orenl@cs.columbia.edu> <1268960401-16680-4-git-send-email-orenl@cs.columbia.edu> <20100320044310.GC2887@count0.beaverton.ibm.com> <20100321172703.GC4174@shareable.org> <20100322010606.GG2887@count0.beaverton.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jamie Lokier , linux-fsdevel@vger.kernel.org, Andreas Dilger , containers@lists.linux-foundation.org To: Matt Helsley Return-path: Received: from hrndva-omtalb.mail.rr.com ([71.74.56.123]:59451 "EHLO hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753716Ab0CVC4M (ORCPT ); Sun, 21 Mar 2010 22:56:12 -0400 Content-Disposition: inline In-Reply-To: <20100322010606.GG2887@count0.beaverton.ibm.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Quoting Matt Helsley (matthltc@us.ibm.com): > On Sun, Mar 21, 2010 at 05:27:03PM +0000, Jamie Lokier wrote: > > Matt Helsley wrote: > > > > That said, if the intent is to allow the restore to be done on > > > > another node with a "similar" filesystem (e.g. created by rsync/node > > > > image), instead of having a coherent distributed filesystem on all > > > > of the nodes then the filename makes sense. > > > > > > Yes, this is the intent. > > > > I would worry about programs which are using files which have been > > deleted, renamed, or (very common) renamed-over by another process > > after being opened, as there's a good chance they will successfully > > open the wrong file after c/r, and corrupt state from then on. > > The code in the patches does check for unlinked files and refuses > to checkpoint if an unlinked file is open. Yes, this limits the usefulness Oh, haha - open/mapped unlinked files. Sorry :) -serge