From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nick Piggin Subject: Re: [C/R v20][PATCH 20/96] c/r: make file_pos_read/write() public Date: Mon, 22 Mar 2010 17:31:13 +1100 Message-ID: <20100322063113.GD17637@laptop> References: <1268960401-16680-1-git-send-email-orenl@cs.columbia.edu> <1268960401-16680-2-git-send-email-orenl@cs.columbia.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org, containers@lists.linux-foundation.org, Matt Helsley , Andreas Dilger To: Oren Laadan Return-path: Received: from cantor.suse.de ([195.135.220.2]:40524 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754009Ab0CVGbT (ORCPT ); Mon, 22 Mar 2010 02:31:19 -0400 Content-Disposition: inline In-Reply-To: <1268960401-16680-2-git-send-email-orenl@cs.columbia.edu> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Thu, Mar 18, 2010 at 08:59:45PM -0400, Oren Laadan wrote: > These two are used in the next patch when calling vfs_read/write() Said next patch didn't seem to make it to fsdevel. Should it at least go to fs/internal.h? > > Signed-off-by: Oren Laadan > Acked-by: Serge E. Hallyn > --- > fs/read_write.c | 10 ---------- > include/linux/fs.h | 10 ++++++++++ > 2 files changed, 10 insertions(+), 10 deletions(-) > > diff --git a/fs/read_write.c b/fs/read_write.c > index b7f4a1f..e258301 100644 > --- a/fs/read_write.c > +++ b/fs/read_write.c > @@ -359,16 +359,6 @@ ssize_t vfs_write(struct file *file, const char __user *buf, size_t count, loff_ > > EXPORT_SYMBOL(vfs_write); > > -static inline loff_t file_pos_read(struct file *file) > -{ > - return file->f_pos; > -} > - > -static inline void file_pos_write(struct file *file, loff_t pos) > -{ > - file->f_pos = pos; > -} > - > SYSCALL_DEFINE3(read, unsigned int, fd, char __user *, buf, size_t, count) > { > struct file *file; > diff --git a/include/linux/fs.h b/include/linux/fs.h > index ebb1cd5..6c08df2 100644 > --- a/include/linux/fs.h > +++ b/include/linux/fs.h > @@ -1543,6 +1543,16 @@ ssize_t rw_copy_check_uvector(int type, const struct iovec __user * uvector, > struct iovec *fast_pointer, > struct iovec **ret_pointer); > > +static inline loff_t file_pos_read(struct file *file) > +{ > + return file->f_pos; > +} > + > +static inline void file_pos_write(struct file *file, loff_t pos) > +{ > + file->f_pos = pos; > +} > + > extern ssize_t vfs_read(struct file *, char __user *, size_t, loff_t *); > extern ssize_t vfs_write(struct file *, const char __user *, size_t, loff_t *); > extern ssize_t vfs_readv(struct file *, const struct iovec __user *, > -- > 1.6.3.3 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html