From: Al Viro <viro@ZenIV.linux.org.uk>
To: Josef Bacik <josef@redhat.com>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
chris.mason@oracle.com, hch@lst.de
Subject: Re: [PATCH] Introduce freeze_super and thaw_super for the fsfreeze ioctl
Date: Tue, 23 Mar 2010 15:09:23 +0000 [thread overview]
Message-ID: <20100323150923.GI30031@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20100323150301.GD2381@localhost.localdomain>
On Tue, Mar 23, 2010 at 11:03:01AM -0400, Josef Bacik wrote:
> > sb is an active reference
> >
>
> I don't understand how this is an active reference? We are talking about
> s_active right?
It's an opened file, for crying out loud! If there is anything that makes
sure that superblock will stay alive, that is it...
And lose the "locked" argument, please. The sane solution is to make
get_active_super() return it unlocked and have your freeze_bdev() simply
grab s_umount. Unconditionally. I'll do the first part in #untested in
a minute or so (and make it grab s_umount in the current variant of code in
fs/block_dev.c); then your patch would shift taking s_umount down into
freeze_super().
next prev parent reply other threads:[~2010-03-23 15:09 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-23 14:22 [PATCH] Introduce freeze_super and thaw_super for the fsfreeze ioctl Josef Bacik
2010-03-23 14:28 ` Al Viro
2010-03-23 14:34 ` Josef Bacik
2010-03-23 14:48 ` Al Viro
2010-03-23 15:03 ` Josef Bacik
2010-03-23 15:09 ` Al Viro [this message]
2010-03-23 15:12 ` Al Viro
2010-03-23 15:15 ` Al Viro
2010-03-23 22:31 ` Nigel Cunningham
2010-03-23 23:18 ` Al Viro
2010-03-23 23:47 ` Al Viro
2010-03-23 23:52 ` Nigel Cunningham
2010-03-23 23:55 ` Nigel Cunningham
2010-03-24 0:21 ` Al Viro
2010-03-24 0:25 ` Nigel Cunningham
2010-03-24 0:03 ` Nigel Cunningham
2010-03-23 18:19 ` Sunil Mushran
2010-03-23 22:25 ` Nigel Cunningham
2010-03-24 1:17 ` Josef Bacik
2010-03-24 5:16 ` Nigel Cunningham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100323150923.GI30031@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=chris.mason@oracle.com \
--cc=hch@lst.de \
--cc=josef@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).