From mboxrd@z Thu Jan  1 00:00:00 1970
From: Al Viro <viro@ZenIV.linux.org.uk>
Subject: Re: [GIT BISECT] first bad commit: 1f36f774 Switch !O_CREAT case to
 use of do_last()
Date: Wed, 24 Mar 2010 16:39:48 +0000
Message-ID: <20100324163948.GR30031@ZenIV.linux.org.uk>
References: <4BAA3493.1030802@panasas.com>
 <20100324160037.GP30031@ZenIV.linux.org.uk>
 <4BAA3828.2070506@panasas.com>
 <20100324160754.GQ30031@ZenIV.linux.org.uk>
 <4BAA398C.5050901@panasas.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	pNFS Mailing List <pnfs@linux-nfs.org>,
	Benny Halevy <bhalevy@panasas.com>,
	"J. Bruce Fields" <bfields@citi.umich.edu>,
	linux-kernel <linux-kernel@vger.kernel.org>
To: Boaz Harrosh <bharrosh@panasas.com>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from zeniv.linux.org.uk ([195.92.253.2]:36532 "EHLO
	ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932219Ab0CXQjt (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Wed, 24 Mar 2010 12:39:49 -0400
Content-Disposition: inline
In-Reply-To: <4BAA398C.5050901@panasas.com>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Wed, Mar 24, 2010 at 06:10:52PM +0200, Boaz Harrosh wrote:
> On 03/24/2010 06:07 PM, Al Viro wrote:
> > On Wed, Mar 24, 2010 at 06:04:56PM +0200, Boaz Harrosh wrote:
> >>> Bloody impressive...  Does that happen to underlying fs or to what you
> >>> are seeing via NFS?
> >>
> >> Only via NFS. All local access is fine.
> >>
> >> After the corruption above I can cd to the local mount cp a fresh copy
> >> of .git/index file and play around just fine.
> >> Once I return to the NFS mounted directory, a git status will do it.
> >> It does not matter if caches are cold (Takes a long time) or hot it happens
> >> every time.
> >>
> >> Weird I know, I'm playing some more with it as we speak
> > 
> > What happens if you export to box running older kernel *or* from box
> > running older kernel?  IOW, is that nfsd or nfs client getting unhappy?
> > I'd suspect the latter, but...
> 
> 
> Good question, I'm just getting to that because currently it's all
> over localhost (same kernel, BTW inside a UML)
> 
> I will try what you said. Please through any other tests on me, if needed.

Very interesting...  Just to see which path we are hitting: add
	if (IS_ERR(nd->intent.open.file))
		printk("foo: %s", pathname);
right after
                error = do_lookup(nd, &nd->last, path);
                if (error)
                        goto exit;
in fs/namei.c:do_last() and see whether we are hitting it or not on objects
that get corrupted.