From: Al Viro <viro@ZenIV.linux.org.uk>
To: Boaz Harrosh <bharrosh@panasas.com>
Cc: linux-fsdevel <linux-fsdevel@vger.kernel.org>,
"J. Bruce Fields" <bfields@citi.umich.edu>,
pNFS Mailing List <pnfs@linux-nfs.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [pnfs] [GIT BISECT] first bad commit: 1f36f774 Switch !O_CREAT case to use of do_last()
Date: Wed, 24 Mar 2010 18:06:22 +0000 [thread overview]
Message-ID: <20100324180622.GS30031@ZenIV.linux.org.uk> (raw)
In-Reply-To: <4BAA52A8.2080304@panasas.com>
On Wed, Mar 24, 2010 at 07:58:00PM +0200, Boaz Harrosh wrote:
> Al hi
>
> Would you like to attempt a revert of this patch (or group of patches)
> Just to get rid of the thought that git bisect was just peeking the
> wrong guy. Maybe it's just something else? Can you understand the
> relevance of all this?
If you see breakage at that commit and do not see it on its parent, we
do have the right guy...
As for reverting, try reverting 781b16775ba0bb55fac0e1757bf0bd87c8879632
first, then this commit.
How consistent are the effects you are seeing from test to test on the same
kernel? This one was very interesting, since it seemed to fail with
-EISDIR while opening .git/objects/pack. Which is a directory and which
should fail with -EISDIR if and only if we pass O_CREAT to open(). And
passing O_CREAT on that one is probably not an intended behaviour of git...
Does anybody else see NFS breakage starting at that commit, BTW? Other
testcases would be useful...
next prev parent reply other threads:[~2010-03-24 18:06 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-24 15:49 [GIT BISECT] first bad commit: 1f36f774 Switch !O_CREAT case to use of do_last() Boaz Harrosh
2010-03-24 16:00 ` Al Viro
2010-03-24 16:04 ` Boaz Harrosh
2010-03-24 16:07 ` Al Viro
2010-03-24 16:10 ` Boaz Harrosh
2010-03-24 16:39 ` Al Viro
2010-03-24 17:15 ` Boaz Harrosh
2010-03-24 17:32 ` [pnfs] " Boaz Harrosh
2010-03-24 17:47 ` Boaz Harrosh
2010-03-24 17:58 ` Boaz Harrosh
2010-03-24 18:06 ` Al Viro [this message]
2010-03-24 18:26 ` Doug Nazar
2010-03-24 18:56 ` Al Viro
2010-03-25 9:39 ` Boaz Harrosh
2010-03-25 10:12 ` Al Viro
2010-03-25 10:22 ` Benny Halevy
2010-03-25 10:31 ` Benny Halevy
2010-03-25 10:49 ` Al Viro
2010-03-25 10:56 ` Benny Halevy
2010-03-25 11:00 ` Al Viro
2010-03-25 11:12 ` Benny Halevy
2010-03-25 11:13 ` Benny Halevy
2010-03-25 11:55 ` Al Viro
2010-03-25 13:00 ` Boaz Harrosh
2010-03-25 13:11 ` Boaz Harrosh
2010-03-25 10:54 ` Al Viro
2010-03-25 11:19 ` Benny Halevy
2010-03-25 12:07 ` Benny Halevy
2010-03-25 12:18 ` Benny Halevy
2010-03-25 13:06 ` Al Viro
2010-03-25 13:30 ` Boaz Harrosh
2010-03-25 13:37 ` Al Viro
2010-03-25 13:45 ` Boaz Harrosh
2010-03-25 14:04 ` Al Viro
2010-03-25 14:27 ` Boaz Harrosh
2010-03-25 15:25 ` Al Viro
2010-03-25 17:28 ` Boaz Harrosh
2010-03-25 17:59 ` Trond Myklebust
2010-03-25 18:06 ` Boaz Harrosh
2010-03-25 18:18 ` Trond Myklebust
2010-03-25 18:33 ` Boaz Harrosh
2010-03-25 13:52 ` Benny Halevy
2010-03-25 14:06 ` Al Viro
2010-03-25 14:07 ` Benny Halevy
2010-03-25 14:36 ` Benny Halevy
2010-03-24 18:02 ` Trond Myklebust
2010-03-24 18:10 ` Trond Myklebust
2010-03-25 9:13 ` Boaz Harrosh
2010-03-25 15:44 ` Trond Myklebust
2010-03-25 10:11 ` Benny Halevy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100324180622.GS30031@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=bfields@citi.umich.edu \
--cc=bharrosh@panasas.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pnfs@linux-nfs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).