From: Dave Chinner <david@fromorbit.com>
To: dmonakhov@openvz.org
Cc: Jan Kara <jack@suse.cz>, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] quota: add per-inode reservaton space sanity checks.
Date: Thu, 1 Apr 2010 10:23:57 +1100 [thread overview]
Message-ID: <20100331232357.GK7671@dastard> (raw)
In-Reply-To: <874ojxc63w.fsf@openvz.org>
On Wed, Mar 31, 2010 at 11:17:39AM +0400, dmonakhov@openvz.org wrote:
> Dave Chinner <david@fromorbit.com> writes:
> > On Wed, Mar 31, 2010 at 09:20:17AM +0400, Dmitry Monakhov wrote:
> >> BTW: I've attached my testcase. I hope it will be useful for you.
> >> It able to catch quota inconsistency caused by incorrect symlink
> >> handling, but it is not reliable for writepage/fallocate bug in ext4.
....
> > There's already a "_require_quota()" function in common.quota that
> Yep. overlooked this one.
> > checks if the filesystem being tested supports quotas and that the
> > quota tools are installed. Can you add these checks to that
> > function?
> >
> > _require_quota also calls _notrun directly, so no need for the
> > quota_supported variable, either.
> >
> > Also, can you use 8 space tabs for indenting?
> Ok, will redo accruing to all your comments. To make the testcase more
> useful i want to perform grep dmesg. But currently this technique
> is not used in xfs-testcase.
It hasn't been used because in the past kernel output is has not been
needed to report a test success or fail. If the test fails, and
there's pertinent infomration in the kernel log, then normally the
developer grabs that him/herself after the failure.
> How can i do it in a convenient way?
What information do you want to grab from the kernel log? If you
make the test linux platform specific (IIRC you already have), then
you could probably just run dmesg and sed/awk/grep/perl the output
to get what you want. Lots of tests take output from something and
then filter it down like this to get the required, anonymised
information to match against the golden output...
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2010-03-31 23:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-30 14:25 [PATCH] quota: add per-inode reservaton space sanity checks Dmitry Monakhov
2010-03-30 15:39 ` Jan Kara
2010-03-30 16:20 ` dmonakhov
2010-03-31 5:20 ` Dmitry Monakhov
2010-03-31 6:55 ` Dave Chinner
2010-03-31 7:17 ` dmonakhov
2010-03-31 23:23 ` Dave Chinner [this message]
2010-03-31 14:29 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100331232357.GK7671@dastard \
--to=david@fromorbit.com \
--cc=dmonakhov@openvz.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).