From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kara Subject: Re: [PATCH] quota: handle io errors in dquot_transfer Date: Tue, 6 Apr 2010 19:41:11 +0200 Message-ID: <20100406174111.GD4420@quack.suse.cz> References: <877homxmg9.fsf@openvz.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org, Jan Kara To: Dmitry Monakhov Return-path: Received: from cantor2.suse.de ([195.135.220.15]:55275 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754649Ab0DFRk7 (ORCPT ); Tue, 6 Apr 2010 13:40:59 -0400 Content-Disposition: inline In-Reply-To: <877homxmg9.fsf@openvz.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon 05-04-10 13:44:54, Dmitry Monakhov wrote: > Currently quota is able to return real error code to caller. > Now it is possible to fix long standing bug with silent quota > corruption in dquot_transfer. > From 5e529864261c7bffe32a8b3d45d7b51749b4512f Mon Sep 17 00:00:00 2001 > From: Dmitry Monakhov > Date: Mon, 5 Apr 2010 13:02:18 +0400 > Subject: [PATCH] quota: handle io errors in dquot_transfer > > Currently if one of dquot structures absent due to some io errors > dquot_transfer will ignore corresponding quotatype. Which is very > bad because result in silent quota inconsistency. But because we were unable to read some quota structure, quota already *is* inconsistent. So it's not like this particular operation would introduce the inconsistency. > Sane implementation must return corresponding error to caller. But sure I agree we should return the fact that we stumbled on quota inconsistency the same way we do it for dquot_alloc_space or dquot_free_space. Honza -- Jan Kara SUSE Labs, CR