From: Jan Kara <jack@suse.cz>
To: Francis Moreau <francis.moro@gmail.com>
Cc: linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] ext2_free_inode(): remove useless call to brelse()
Date: Thu, 8 Apr 2010 11:57:48 +0200 [thread overview]
Message-ID: <20100408095747.GB20488@quack.suse.cz> (raw)
In-Reply-To: <38b2ab8a1003260607p42382139te0be1a4ba4b3b8bc@mail.gmail.com>
On Fri 26-03-10 14:07:00, Francis Moreau wrote:
> This patch removes a useless call to brelse(bitmap_bh) since at that
> point bitmap_bh is NULL.
>
> It also converts the last brelse(bitmap_bh) into a __brelse(bitmap_bh)
> since at that point bitmap_bh is no more NULL.
The cleanup looks fine. Only I'd use normal brelse instead of __brelse
at the end. The compiler should figure out itself that the check is
unnecessary (if not, the cost of extra test is negligible in that path
anyway) and you don't have to think twice when looking at the function.
Also you don't have to initialize bitmap_bh to NULL after your cleanups.
So I've taken your patch with these two minor changes.
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
next prev parent reply other threads:[~2010-04-08 9:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-26 13:07 [PATCH] ext2_free_inode(): remove useless call to brelse() Francis Moreau
2010-04-08 9:57 ` Jan Kara [this message]
2010-04-08 10:01 ` Jan Kara
2010-04-13 9:02 ` Francis Moreau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100408095747.GB20488@quack.suse.cz \
--to=jack@suse.cz \
--cc=francis.moro@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).