From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: afs_fsync Date: Sun, 18 Apr 2010 21:46:53 +0200 Message-ID: <20100418194653.GA20069@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-afs@lists.infradead.org, linux-fsdevel@vger.kernel.org To: dhowells@redhat.com Return-path: Received: from verein.lst.de ([213.95.11.210]:43988 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752269Ab0DRTrU (ORCPT ); Sun, 18 Apr 2010 15:47:20 -0400 Content-Disposition: inline Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Dave, I've been looking at afs_fsync a bit lately and don't quite understanding what's going on there. As of 2.6.32 we always write out all data before calling into ->fsync. From my very unscientific exploration into afs_fsync it's doing exactly that data writeout again, just in a rather complicated way, and then marks the inode as having dirty pages again, which is not very helpful inside ->fsync. Any chance you could explain what's really going on there?