Re: [PATCH] quota: Make quota stat accounting lockless.

[Jan Kara <jack@suse.cz>]

On Mon 26-04-10 17:16:23, Jan Kara wrote:
> On Fri 23-04-10 09:31:41, Dmitry Monakhov wrote:
> > 
> > I've written this patch long time ago, it is pretty simple, and
> > allow more non obvious locking optimization to be done later.
>   The patch looks OK to me. Will merge it.
  Hmm, maybe I spoke to soon. One question:

> > +void dqstats_inc(unsigned int type)
> > +{
> > +#ifdef CONFIG_SMP
> > +	per_cpu_ptr(dqstats_pcpu, smp_processor_id())->stat[type]++;
> > +#else
> > +	dqstats[type]++;
> > +#endif
> > +}
> > +
> > +void dqstats_dec(unsigned int type)
> > +{
> > +#ifdef CONFIG_SMP
> > +	per_cpu_ptr(dqstats_pcpu, smp_processor_id())->stat[type]--;
> > +#else
> > +	dqstats[type]--;
> > +#endif
> > +}
  Why not make these two functions inline? Since they are used
also from quota_tree.c and quota_v1.c, we'd need to move them to a
quota.h header in that case.

								Honza

								Honza
-- 
Jan Kara <jack@suse.cz>
SUSE Labs, CR