From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Chinner Subject: Re: Direct aio_write/truncate question Date: Tue, 27 Apr 2010 09:55:03 +1000 Message-ID: <20100426235503.GA9703@dastard> References: <87633hdr6n.fsf@openvz.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Andrew Morton , jens.axboe@oracle.com To: Dmitry Monakhov Return-path: Content-Disposition: inline In-Reply-To: <87633hdr6n.fsf@openvz.org> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Sat, Apr 24, 2010 at 03:29:36PM +0400, Dmitry Monakhov wrote: > My be my question appeared to obvious for someone, but still > > fd = open("a", O_DIRECT, ) > fd2 = open("b", O_DIRECT, ) > write(fd, buf ,size) /* allocate blocks for a file */ > fsync(fd) /* Now, it is guaranteed that blocks are allocated.*/ > /* Submit async rewrite request */ > io_prep_pwrite(io, fd, io->u.c.buf, size, 0); > io_submit(myctx, 1, io); /* Io is in flight after this */ > /* Ok, truncate the file */ > ftruncate(fd, 0) > /* Reuse truncated block blocks for a new file */ > write(fd2,buf ,size) /* old a's blocks belongs to b now. */ > > What protect us from aio request to rewrite content of new file? The filesystem is supposed to serialise truncate vs write races. i.e. the truncate will occur either before the write is executed or after it has completed, not while it is running. Cheers, Dave. -- Dave Chinner david@fromorbit.com