* [patch 6/7] vfs: clarify that nonseekable_open() will never fail
@ 2010-04-27 21:24 akpm
0 siblings, 0 replies; only message in thread
From: akpm @ 2010-04-27 21:24 UTC (permalink / raw)
To: viro; +Cc: linux-fsdevel, akpm, dmitry.torokhov, arnd, dtor, jkacur
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: John Kacur <jkacur@redhat.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
fs/open.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff -puN fs/open.c~vfs-clarify-that-nonseekable_open-will-never-fail fs/open.c
--- a/fs/open.c~vfs-clarify-that-nonseekable_open-will-never-fail
+++ a/fs/open.c
@@ -1198,7 +1198,9 @@ EXPORT_SYMBOL(generic_file_open);
/*
* This is used by subsystems that don't want seekable
- * file descriptors
+ * file descriptors. The function is not supposed to ever fail, the only
+ * reason it returns an 'int' and not 'void' is so that it can be plugged
+ * directly into file_operations structure.
*/
int nonseekable_open(struct inode *inode, struct file *filp)
{
_
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2010-04-27 21:24 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-04-27 21:24 [patch 6/7] vfs: clarify that nonseekable_open() will never fail akpm
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).