From mboxrd@z Thu Jan 1 00:00:00 1970 From: akpm@linux-foundation.org Subject: [patch 6/7] vfs: clarify that nonseekable_open() will never fail Date: Tue, 27 Apr 2010 14:24:00 -0700 Message-ID: <201004272124.o3RLO0d9020909@imap1.linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit Cc: linux-fsdevel@vger.kernel.org, akpm@linux-foundation.org, dmitry.torokhov@gmail.com, arnd@arndb.de, dtor@mail.ru, jkacur@redhat.com To: viro@zeniv.linux.org.uk Return-path: Received: from smtp1.linux-foundation.org ([140.211.169.13]:58025 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757077Ab0D0VYg (ORCPT ); Tue, 27 Apr 2010 17:24:36 -0400 Sender: linux-fsdevel-owner@vger.kernel.org List-ID: From: Dmitry Torokhov Signed-off-by: Dmitry Torokhov Acked-by: Arnd Bergmann Acked-by: John Kacur Cc: Al Viro Signed-off-by: Andrew Morton --- fs/open.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff -puN fs/open.c~vfs-clarify-that-nonseekable_open-will-never-fail fs/open.c --- a/fs/open.c~vfs-clarify-that-nonseekable_open-will-never-fail +++ a/fs/open.c @@ -1198,7 +1198,9 @@ EXPORT_SYMBOL(generic_file_open); /* * This is used by subsystems that don't want seekable - * file descriptors + * file descriptors. The function is not supposed to ever fail, the only + * reason it returns an 'int' and not 'void' is so that it can be plugged + * directly into file_operations structure. */ int nonseekable_open(struct inode *inode, struct file *filp) { _