Re: [PATCH 4/3] quota: remove sb_has_quota_active in get/set_info

[Jan Kara <jack@suse.cz>]

On Fri 07-05-10 12:35:40, Christoph Hellwig wrote:
> The methods already do these checks, so remove them in the quotactl
> implementation to allow non-VFS quota implementations to also support
> these calls.
  I've merged all four patches into my tree.

								Honza
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> 
> Index: linux-2.6/fs/quota/quota.c
> ===================================================================
> --- linux-2.6.orig/fs/quota/quota.c	2010-05-07 18:28:26.438025430 +0200
> +++ linux-2.6/fs/quota/quota.c	2010-05-07 18:30:30.919283361 +0200
> @@ -113,8 +113,6 @@ static int quota_getinfo(struct super_bl
>  	struct if_dqinfo info;
>  	int ret;
>  
> -	if (!sb_has_quota_active(sb, type))
> -		return -ESRCH;
>  	if (!sb->s_qcop->get_info)
>  		return -ENOSYS;
>  	ret = sb->s_qcop->get_info(sb, type, &info);
> @@ -129,8 +127,6 @@ static int quota_setinfo(struct super_bl
>  
>  	if (copy_from_user(&info, addr, sizeof(info)))
>  		return -EFAULT;
> -	if (!sb_has_quota_active(sb, type))
> -		return -ESRCH;
>  	if (!sb->s_qcop->set_info)
>  		return -ENOSYS;
>  	return sb->s_qcop->set_info(sb, type, &info);
-- 
Jan Kara <jack@suse.cz>
SUSE Labs, CR