From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Wilcox Subject: Re: [RFC][PATCH 2/4][cr]: Define __f_setown_uid() Date: Wed, 12 May 2010 08:07:41 -0600 Message-ID: <20100512140741.GF10452@parisc-linux.org> References: <1273617500-13653-1-git-send-email-sukadev@linux.vnet.ibm.com> <1273617500-13653-3-git-send-email-sukadev@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Oren Laadan , Matt Helsley , serue@us.ibm.com, Containers , linux-fsdevel@vger.kernel.org To: Sukadev Bhattiprolu Return-path: Received: from palinux.external.hp.com ([192.25.206.14]:34075 "EHLO mail.parisc-linux.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754157Ab0ELOHn (ORCPT ); Wed, 12 May 2010 10:07:43 -0400 Content-Disposition: inline In-Reply-To: <1273617500-13653-3-git-send-email-sukadev@linux.vnet.ibm.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Tue, May 11, 2010 at 03:38:18PM -0700, Sukadev Bhattiprolu wrote: > __f_setown_uid() is same as __f_setown(), except that instead of assuming the > uid and euid of current process, it expects them to be passed in as parameters. > > This interface will be useful when checkpointing and restarting an application > that has a 'file owner' specified for any of the application's open files. > The uid, euid of the process setting up the owner is saved in the checkpoint > image. When the application is restarted, the save uid and euid values are > restored. There are only four callers of __f_setown in the kernel. I'd rather see __f_setown converted to take the arguments directly. -- Matthew Wilcox Intel Open Source Technology Centre "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step."