From: Jan Kara <jack@suse.cz>
To: Christoph Hellwig <hch@infradead.org>
Cc: jack@suse.cz, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 3/6] dquot: move unmount handling into the filesystem
Date: Tue, 18 May 2010 00:58:55 +0200 [thread overview]
Message-ID: <20100517225855.GI3364@quack.suse.cz> (raw)
In-Reply-To: <20100512194453.848250753@bombadil.infradead.org>
On Wed 12-05-10 15:44:11, Christoph Hellwig wrote:
> Currently the VFS calls into the quotactl interface for unmounting
> filesystems. This means filesystems with their own quota handling
> can't easily distinguish between user-space originating quotaoff
> and an unount. Instead move the responsibily of the unmount handling
> into the filesystem to be consistent with all other dquot handling.
>
> Note that we do call dquot_disable a lot later now, e.g. after
> a sync_filesystem. But this is fine as the quota code takes care
> of writing out the quota file by itself.
Well, we don't really write quota file by ourselves but we do the writes
via blockdev's mapping and that is synced after put_super is called so you
are right it should be fine.
> Index: linux-2.6/fs/ocfs2/super.c
> ===================================================================
> --- linux-2.6.orig/fs/ocfs2/super.c 2010-05-10 22:42:36.910005803 +0200
> +++ linux-2.6/fs/ocfs2/super.c 2010-05-10 23:22:59.035004827 +0200
> @@ -1595,6 +1595,8 @@ static void ocfs2_put_super(struct super
> {
> mlog_entry("(0x%p)\n", sb);
>
> + dquot_disable(sb, -1, DQUOT_LIMITS_ENABLED);
> +
OCFS2 disables quotas completely on it's own slightly later in
ocfs2_dismount_volume so you can just remove this.
Otherwise the patch looks fine.
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
next prev parent reply other threads:[~2010-05-17 22:59 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-12 19:44 [PATCH 0/6] more quota cleanups Christoph Hellwig
2010-05-12 19:44 ` [PATCH 1/6] dquot: move remount handling into the filesystem Christoph Hellwig
2010-05-17 22:34 ` Jan Kara
2010-05-19 10:55 ` Christoph Hellwig
2010-05-19 13:47 ` Jan Kara
2010-05-12 19:44 ` [PATCH 2/6] quota: kill the vfs_dq_off and vfs_dq_quota_on_remount wrappers Christoph Hellwig
2010-05-17 22:46 ` Jan Kara
2010-05-12 19:44 ` [PATCH 3/6] dquot: move unmount handling into the filesystem Christoph Hellwig
2010-05-17 22:58 ` Jan Kara [this message]
2010-05-19 11:03 ` Christoph Hellwig
2010-05-12 19:44 ` [PATCH 4/6] quota: drop remount argument to ->quota_on and ->quota_off Christoph Hellwig
2010-05-17 23:00 ` Jan Kara
2010-05-12 19:44 ` [PATCH 5/6] quota: explicitly set ->dq_op and ->s_qcop Christoph Hellwig
2010-05-17 23:06 ` Jan Kara
2010-05-19 11:07 ` Christoph Hellwig
2010-05-12 19:44 ` [PATCH 6/6] quota: rename default quotactl methods to dqout_ Christoph Hellwig
2010-05-17 23:09 ` Jan Kara
2010-05-19 11:07 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2010-05-19 11:16 [PATCH 0/6] more quota cleanups V2 Christoph Hellwig
2010-05-19 11:16 ` [PATCH 3/6] dquot: move unmount handling into the filesystem Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100517225855.GI3364@quack.suse.cz \
--to=jack@suse.cz \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).