From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH 3/6] dquot: move unmount handling into the filesystem
Date: Wed, 19 May 2010 07:03:57 -0400
Message-ID: <20100519110357.GB5106@infradead.org>
References: <20100512194408.620390318@bombadil.infradead.org> <20100512194453.848250753@bombadil.infradead.org> <20100517225855.GI3364@quack.suse.cz>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Christoph Hellwig <hch@infradead.org>,
	linux-fsdevel@vger.kernel.org
To: Jan Kara <jack@suse.cz>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from bombadil.infradead.org ([18.85.46.34]:52056 "EHLO
	bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1756032Ab0ESLD6 (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Wed, 19 May 2010 07:03:58 -0400
Content-Disposition: inline
In-Reply-To: <20100517225855.GI3364@quack.suse.cz>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Tue, May 18, 2010 at 12:58:55AM +0200, Jan Kara wrote:
> > Index: linux-2.6/fs/ocfs2/super.c
> > ===================================================================
> > --- linux-2.6.orig/fs/ocfs2/super.c	2010-05-10 22:42:36.910005803 +0200
> > +++ linux-2.6/fs/ocfs2/super.c	2010-05-10 23:22:59.035004827 +0200
> > @@ -1595,6 +1595,8 @@ static void ocfs2_put_super(struct super
> >  {
> >  	mlog_entry("(0x%p)\n", sb);
> >  
> > +	dquot_disable(sb, -1, DQUOT_LIMITS_ENABLED);
> > +
>   OCFS2 disables quotas completely on it's own slightly later in
> ocfs2_dismount_volume so you can just remove this.
>   Otherwise the patch looks fine.

I'll leave it out for the next respin.