From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kara Subject: Re: [PATCH 12/12] ext2: add error handling for dquot_initialize Date: Thu, 20 May 2010 19:30:44 +0200 Message-ID: <20100520173044.GH3395@quack.suse.cz> References: <1274248928-5113-4-git-send-email-dmonakhov@openvz.org> <1274248928-5113-5-git-send-email-dmonakhov@openvz.org> <1274248928-5113-6-git-send-email-dmonakhov@openvz.org> <1274248928-5113-7-git-send-email-dmonakhov@openvz.org> <1274248928-5113-8-git-send-email-dmonakhov@openvz.org> <1274248928-5113-9-git-send-email-dmonakhov@openvz.org> <1274248928-5113-10-git-send-email-dmonakhov@openvz.org> <1274248928-5113-11-git-send-email-dmonakhov@openvz.org> <1274248928-5113-12-git-send-email-dmonakhov@openvz.org> <1274248928-5113-13-git-send-email-dmonakhov@openvz.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org, jack@suse.cz, hch@infradead.org To: Dmitry Monakhov Return-path: Received: from cantor.suse.de ([195.135.220.2]:45214 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752398Ab0ETRaw (ORCPT ); Thu, 20 May 2010 13:30:52 -0400 Content-Disposition: inline In-Reply-To: <1274248928-5113-13-git-send-email-dmonakhov@openvz.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed 19-05-10 10:02:08, Dmitry Monakhov wrote: > > Signed-off-by: Dmitry Monakhov > --- > fs/ext2/ialloc.c | 5 ++++- > fs/ext2/inode.c | 11 +++++++++-- > fs/ext2/namei.c | 40 ++++++++++++++++++++++++++++++---------- > 3 files changed, 43 insertions(+), 13 deletions(-) > ... > diff --git a/fs/ext2/namei.c b/fs/ext2/namei.c > index 71efb0e..d47e549 100644 > --- a/fs/ext2/namei.c > +++ b/fs/ext2/namei.c > @@ -157,7 +162,9 @@ static int ext2_symlink (struct inode * dir, struct dentry * dentry, > if (l > sb->s_blocksize) > goto out; > > - dquot_initialize(dir); > + err = dquot_initialize(dir); > + if (err) > + return err; Should be 'goto out' for consistency and in other functions below as well.. Honza -- Jan Kara SUSE Labs, CR