From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nick Piggin Subject: [patch] block: bd_start_claiming fix module refcount Date: Wed, 26 May 2010 01:50:21 +1000 Message-ID: <20100525155021.GC20853@laptop> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii To: linux-fsdevel@vger.kernel.org, Tejun Heo , Jens Axboe , Andrew Morton Return-path: Received: from cantor2.suse.de ([195.135.220.15]:60252 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753205Ab0EYPuZ (ORCPT ); Tue, 25 May 2010 11:50:25 -0400 Content-Disposition: inline Sender: linux-fsdevel-owner@vger.kernel.org List-ID: bd_start_claiming has an unbalanced module_put introduced in 6b4517a79. Signed-off-by: Nick Piggin --- Index: linux-2.6/fs/block_dev.c =================================================================== --- linux-2.6.orig/fs/block_dev.c +++ linux-2.6/fs/block_dev.c @@ -738,6 +738,7 @@ static struct block_device *bd_start_cla return ERR_PTR(-ENXIO); whole = bdget_disk(disk, 0); + module_put(disk->fops->owner); put_disk(disk); if (!whole) return ERR_PTR(-ENOMEM);