* [PATCH] writeback: fix non-integrity write-back
@ 2010-05-26 13:08 Artem Bityutskiy
2010-05-26 13:21 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Artem Bityutskiy @ 2010-05-26 13:08 UTC (permalink / raw)
To: Jens Axboe; +Cc: LKML, linux-fsdevel
From: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
This is a fix for commit 7c8a3554. Note, I only compile-tested
this.
Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
---
fs/fs-writeback.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c
index ea8592b..0242855 100644
--- a/fs/fs-writeback.c
+++ b/fs/fs-writeback.c
@@ -920,7 +920,7 @@ long wb_do_writeback(struct bdi_writeback *wb, int force_wait)
if (force_wait)
work->args.sync_mode = args.sync_mode = WB_SYNC_ALL;
- post_clear = WB_SYNC_ALL || args.sb_pinned;
+ post_clear = args.sync_mode == WB_SYNC_ALL || args.sb_pinned;
/*
* If this isn't a data integrity operation, just notify
--
1.6.6.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] writeback: fix non-integrity write-back
2010-05-26 13:08 [PATCH] writeback: fix non-integrity write-back Artem Bityutskiy
@ 2010-05-26 13:21 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2010-05-26 13:21 UTC (permalink / raw)
To: Artem Bityutskiy; +Cc: LKML, linux-fsdevel
On Wed, May 26 2010, Artem Bityutskiy wrote:
> From: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
>
> This is a fix for commit 7c8a3554. Note, I only compile-tested
> this.
>
> Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
> ---
> fs/fs-writeback.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c
> index ea8592b..0242855 100644
> --- a/fs/fs-writeback.c
> +++ b/fs/fs-writeback.c
> @@ -920,7 +920,7 @@ long wb_do_writeback(struct bdi_writeback *wb, int force_wait)
> if (force_wait)
> work->args.sync_mode = args.sync_mode = WB_SYNC_ALL;
>
> - post_clear = WB_SYNC_ALL || args.sb_pinned;
> + post_clear = args.sync_mode == WB_SYNC_ALL || args.sb_pinned;
>
> /*
> * If this isn't a data integrity operation, just notify
Auch, indeed that's a dumb bug. It wont have a huge effect, but it'll
serialize some operations that need not be.
I'll queue it up, with the issue that Christoph reported as well, then
both of these want to go upstream soon.
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-05-26 13:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-26 13:08 [PATCH] writeback: fix non-integrity write-back Artem Bityutskiy
2010-05-26 13:21 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).