From: Al Viro <viro@ZenIV.linux.org.uk>
To: Erik van der Kouwe <vdkouwe@cs.vu.nl>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Fam Zheng <famcool@gmail.com>
Subject: Re: [PATCH] fs/minix: bugfix, number of indirect block ptrs per block depends on block size
Date: Thu, 27 May 2010 05:35:31 +0100 [thread overview]
Message-ID: <20100527043531.GY31073@ZenIV.linux.org.uk> (raw)
In-Reply-To: <4BFCF1EB.20709@cs.vu.nl>
On Wed, May 26, 2010 at 12:03:23PM +0200, Erik van der Kouwe wrote:
> +#define INDIRCOUNT(sb) ((sb)->s_blocksize / 4)
ITYM (1 << ((sb)->s_blocksize_bits - 2))
Give gcc at least a chance to turn the uses of that into shifts...
Applied with such change.
prev parent reply other threads:[~2010-05-27 4:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-26 10:03 [PATCH] fs/minix: bugfix, number of indirect block ptrs per block depends on block size Erik van der Kouwe
2010-05-26 21:54 ` Jan Kara
2010-05-27 16:01 ` Al Viro
2010-05-27 17:11 ` Erik van der Kouwe
2010-05-27 17:17 ` Jan Kara
2010-05-27 4:35 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100527043531.GY31073@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=famcool@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vdkouwe@cs.vu.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).