From mboxrd@z Thu Jan  1 00:00:00 1970
From: tytso@mit.edu
Subject: Re: [PATCH 1/2] drop unused dentry argument to ->fsync
Date: Fri, 28 May 2010 07:42:24 -0400
Message-ID: <20100528114224.GF26177@thunk.org>
References: <20100526155325.GA8396@lst.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org
To: Christoph Hellwig <hch@lst.de>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from thunk.org ([69.25.196.29]:41913 "EHLO thunker.thunk.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754553Ab0E1Lme (ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
	Fri, 28 May 2010 07:42:34 -0400
Content-Disposition: inline
In-Reply-To: <20100526155325.GA8396@lst.de>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Wed, May 26, 2010 at 05:53:25PM +0200, Christoph Hellwig wrote:
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> 
> Index: linux-2.6/arch/powerpc/platforms/cell/spufs/file.c
> ===================================================================
> --- linux-2.6.orig/arch/powerpc/platforms/cell/spufs/file.c	2010-05-25 19:28:04.965004819 +0200
> +++ linux-2.6/arch/powerpc/platforms/cell/spufs/file.c	2010-05-25 19:55:33.804006007 +0200
> @@ -1849,8 +1849,7 @@ out:
>  	return ret;
>  }
>  
> -static int spufs_mfc_fsync(struct file *file, struct dentry *dentry,
> -			   int datasync)
> +static int spufs_mfc_fsync(struct file *file int datasync)
                                             ^^^^^
Typo: Missing comma, this won't compile.

There will also be a slight merge conflict with fs/ext4/fsync.c, but
the resolution should be pretty straightforward.

						- Ted