From mboxrd@z Thu Jan 1 00:00:00 1970 From: Al Viro Subject: Re: [PATCH 1/2] drop unused dentry argument to ->fsync Date: Fri, 28 May 2010 14:18:44 +0100 Message-ID: <20100528131844.GJ31073@ZenIV.linux.org.uk> References: <20100526155325.GA8396@lst.de> <20100528114224.GF26177@thunk.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Christoph Hellwig , linux-fsdevel@vger.kernel.org To: Theodore Tso Return-path: Received: from zeniv.linux.org.uk ([195.92.253.2]:60441 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752675Ab0E1NSq (ORCPT ); Fri, 28 May 2010 09:18:46 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Fri, May 28, 2010 at 08:35:26AM -0400, Theodore Tso wrote: > > On May 28, 2010, at 7:42 AM, tytso@mit.edu wrote: > > > On Wed, May 26, 2010 at 05:53:25PM +0200, Christoph Hellwig wrote: > >> Signed-off-by: Christoph Hellwig > >> > >> Index: linux-2.6/arch/powerpc/platforms/cell/spufs/file.c > >> =================================================================== > >> --- linux-2.6.orig/arch/powerpc/platforms/cell/spufs/file.c 2010-05-25 19:28:04.965004819 +0200 > >> +++ linux-2.6/arch/powerpc/platforms/cell/spufs/file.c 2010-05-25 19:55:33.804006007 +0200 > >> @@ -1849,8 +1849,7 @@ out: > >> return ret; > >> } > >> > >> -static int spufs_mfc_fsync(struct file *file, struct dentry *dentry, > >> - int datasync) > >> +static int spufs_mfc_fsync(struct file *file int datasync) > > ^^^^^ > > Typo: Missing comma, this won't compile. > > Oops, looks like emacs in tty mode (when fired from mutt) screwed up my screen, and I saw something quite different from what you posted. Sorry about that, please ignore. No, you are right, it's a typo; I've caught two more (ntfs and ocfs2, IIRC), but actually missed that one.