From: tytso@mit.edu
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Christoph Hellwig <hch@lst.de>, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 1/2] drop unused dentry argument to ->fsync
Date: Fri, 28 May 2010 09:50:18 -0400 [thread overview]
Message-ID: <20100528135018.GH26177@thunk.org> (raw)
In-Reply-To: <20100528131844.GJ31073@ZenIV.linux.org.uk>
On Fri, May 28, 2010 at 02:18:44PM +0100, Al Viro wrote:
> On Fri, May 28, 2010 at 08:35:26AM -0400, Theodore Tso wrote:
> >
> > On May 28, 2010, at 7:42 AM, tytso@mit.edu wrote:
> >
> > > On Wed, May 26, 2010 at 05:53:25PM +0200, Christoph Hellwig wrote:
> > >> Signed-off-by: Christoph Hellwig <hch@lst.de>
> > >>
> > >> Index: linux-2.6/arch/powerpc/platforms/cell/spufs/file.c
> > >> ===================================================================
> > >> --- linux-2.6.orig/arch/powerpc/platforms/cell/spufs/file.c 2010-05-25 19:28:04.965004819 +0200
> > >> +++ linux-2.6/arch/powerpc/platforms/cell/spufs/file.c 2010-05-25 19:55:33.804006007 +0200
> > >> @@ -1849,8 +1849,7 @@ out:
> > >> return ret;
> > >> }
> > >>
> > >> -static int spufs_mfc_fsync(struct file *file, struct dentry *dentry,
> > >> - int datasync)
> > >> +static int spufs_mfc_fsync(struct file *file int datasync)
> > > ^^^^^
> > > Typo: Missing comma, this won't compile.
> >
> > Oops, looks like emacs in tty mode (when fired from mutt) screwed up my screen, and I saw something quite different from what you posted. Sorry about that, please ignore.
>
> No, you are right, it's a typo; I've caught two more (ntfs and ocfs2, IIRC),
> but actually missed that one.
Ah, so it was actually the Mac's e-mail that screwed up the display.
Heh. (Yeah, I use a Mac for reading in bed, what can I say, it's
lightweight. :-)
Sorry for the confusion.
- Ted
prev parent reply other threads:[~2010-05-28 13:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-26 15:53 [PATCH 1/2] drop unused dentry argument to ->fsync Christoph Hellwig
2010-05-28 11:42 ` tytso
2010-05-28 12:35 ` Theodore Tso
2010-05-28 13:18 ` Al Viro
2010-05-28 13:50 ` tytso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100528135018.GH26177@thunk.org \
--to=tytso@mit.edu \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).