From: Christoph Hellwig <hch@infradead.org>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Sage Weil <sage@newdream.net>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [git pull] vfs pile, part 2
Date: Sat, 29 May 2010 05:07:08 -0400 [thread overview]
Message-ID: <20100529090708.GA20606@infradead.org> (raw)
In-Reply-To: <20100528194753.GL31073@ZenIV.linux.org.uk>
On Fri, May 28, 2010 at 08:47:53PM +0100, Al Viro wrote:
> My apologies, I thought you'd been Cc'd on the discussions with Ian concerning
> that stuff, but...
>
> The bottom line: "autofs4: always use lookup for lookup" is needed for them
> and it had to be reverted since it'd been FUBAR.
>
> Details: we really, *really* can not do things in ->d_revalidate() and count
> on ->lookup() to come and finish them. Think for a minute and you'll see why -
> between these two calls we allocate a dentry to pass to ->lookup(). What
> happens if that allocation fails?
>
> And without that patch your stuff breaks autofs4. So it's waiting for the
> ->d_revalidate() interface redesign. Hopefully in the coming cycle...
In addition to that autofs also needs either major surgery or to be
dropped. If we want to do the latter we'd be better of to strongly
deprecate it now.
next prev parent reply other threads:[~2010-05-29 9:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-28 15:51 [git pull] vfs pile, part 2 Al Viro
2010-05-28 19:27 ` Sage Weil
2010-05-28 19:47 ` Al Viro
2010-05-29 9:07 ` Christoph Hellwig [this message]
2010-06-02 19:57 ` Geert Uytterhoeven
-- strict thread matches above, loose matches on Subject: below --
2011-05-28 17:25 Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100529090708.GA20606@infradead.org \
--to=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sage@newdream.net \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).