From: Borislav Petkov <bp@alien8.de>
To: Changli Gao <xiaosuo@gmail.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] fs: optimize mpage_readpage()
Date: Sat, 29 May 2010 15:46:25 +0200 [thread overview]
Message-ID: <20100529134625.GC25092@liondog.tnic> (raw)
In-Reply-To: <AANLkTimtX4HSql73IEAwOBqC2-R25713IgfihGR-fQm9@mail.gmail.com>
From: Changli Gao <xiaosuo@gmail.com>
Date: Sat, May 29, 2010 at 09:26:47PM +0800
> Did the compiler warning appear after applying my patch? It doesn't
> happen when I testing it.
yep, using gcc (Debian 4.4.4-2) 4.4.4 here.
> And I don't pass bio to do_mpage_readpage(), but I pass NULL instead.
True, but you still need that bio pointer so you might just as well set
it to NULL as the original code does.
--
Regards/Gruss,
Boris.
next prev parent reply other threads:[~2010-05-29 13:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-29 1:18 [PATCH 1/2] fs: optimize mpage_readpage() Changli Gao
2010-05-29 12:10 ` Borislav Petkov
2010-05-29 13:26 ` Changli Gao
2010-05-29 13:46 ` Borislav Petkov [this message]
2010-05-29 14:17 ` Changli Gao
2010-06-04 7:19 ` Al Viro
2010-06-04 8:13 ` Borislav Petkov
2010-06-04 8:30 ` Al Viro
2010-06-04 10:18 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100529134625.GC25092@liondog.tnic \
--to=bp@alien8.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=xiaosuo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).